Tabs: move animation-related utilities into separate utils file. #62946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 28, 2024
35 tasks
|
I addressed all comments, please re-review @ciampo @WordPress/gutenberg-components :) |
ciampo
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
LGTM 🚀
Can be merged once open feedback is addressed.
As for the next steps, here's a recap of what I gathered from all conversations in this PR:
- move
useEventto the@wordpress/composepackage - resume work on Support a new API for useResizeObserver #41001, and see if we can provide a new version of the hook based on modern Web technologies that satisfies the requirements of its consumers in the editor, providing a good, non-breaking migration strategy
- [optional] review the structure and organisation of the
packages/components/src/utils/folder - refactor
ToggleGroupControlto use the newly introduced utils to animate its indicator without usingframer-motion
There was a problem hiding this comment.
Should this file be renamed use-track-element-offset-rec.ts to match how other files are named, and moved to the hooks directory?
There was a problem hiding this comment.
It contains multiple utilities related to tracking and obtaining element rects, and they are a mix of hooks and other things, so it wouldn't make sense to do so without completely dislocating all of these utilities. It's why I raised the point that the utils folder just doesn't have a good structure.
|
@ciampo yep, got all of that on my backlog already 👍 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…dPress#62946) * Split animation logic into multiple separate composable utilities. * JSDoc tweak. * Tabs: move animation-related utilities into separate utils file. * Rename hook and update some docs. * Revert eslint rule and disable for the file. * Re-organize utils to fit current structure better. Co-authored-by: DaniGuardiola <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mirka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: #62942 needs to be merged first
What?
Move animation-related utilities from Tabs into separate utils file.
Why?
For future use in other components. Related: #62942